Add tests for auth middleware, clan missions, admin roles, and pvp-config - #182
Open
Sparksx wants to merge 1 commit into
Open
Add tests for auth middleware, clan missions, admin roles, and pvp-config#182Sparksx wants to merge 1 commit into
Sparksx wants to merge 1 commit into
Conversation
…nfig Covers 5 previously untested modules with 50 new test cases: - server/middleware/auth: requireAuth, requireRole, socketAuth (JWT, roles, socket) - server/routes/auth: module load safety, guest username format, validation contracts - src/game/clan-missions: event wiring, full-gear-swap detection, flush debouncing - src/game/admin: getUserRole, isStaff, isAdmin across all role states - shared/pvp-config: matchmaking constant invariants (completes shared/ coverage) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5e2sXbt71QfTpEXEPSkpf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireAuthheader parsing, JWT verification, token expiry handling;requireRolerole matching and DB error handling;socketAuthWebSocket JWT verificationHero_+ 6 hex chars), default game state shape, settings/profile-picture validation boundariesgetUserRole,isStaff,isAdminacross all role states including null/missing usershared/directory coverageTest plan
npx vitest run)🤖 Generated with Claude Code
https://claude.ai/code/session_01H5e2sXbt71QfTpEXEPSkpf
Generated by Claude Code