Fix sparse vectors eadd on CPU #230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Replace absent vectors' elements with corresponding fill_value in sparse to sparse vectors ewiseadd operation on CPU
List of changes
Fix implementation of
src/cpu/cpu_v_eadd.hpp:spla::Algo_v_eadd_cpu::execute_spNspType of changes
Testing strategy
Run vector tests without OpenCL accelerators:
SPLA_GTEST_MAIN_WITH_FINALIZE_PLATFORM(0)in tests/test_vector.cpp:500with
SPLA_GTEST_MAIN_WITH_FINALIZE_NO_ACC()Now test
vector.eadd_sub_pow2works fine on CPU