Skip to content

Conversation

@vkutuev
Copy link
Contributor

@vkutuev vkutuev commented Apr 8, 2025

Short description

Replace absent vectors' elements with corresponding fill_value in sparse to sparse vectors ewiseadd operation on CPU

List of changes

Fix implementation of src/cpu/cpu_v_eadd.hpp:spla::Algo_v_eadd_cpu::execute_spNsp

Type of changes

  • bug-fix (change which fixes Vector: sparse ewiseadd bug (cpu) #229 )
  • new-feature (change which proposes new feature or functionality)
  • breaking-change (change which brakes compatibility of api or etc.)

Testing strategy

Run vector tests without OpenCL accelerators:

  • Replace SPLA_GTEST_MAIN_WITH_FINALIZE_PLATFORM(0) in tests/test_vector.cpp:500
    with SPLA_GTEST_MAIN_WITH_FINALIZE_NO_ACC()
  • Rebuild project
  • Run tests

Now test vector.eadd_sub_pow2 works fine on CPU

@vkutuev vkutuev requested review from EgorOrachyov and gsvgit April 8, 2025 13:15
@vkutuev vkutuev merged commit 74658a9 into main Apr 9, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vector: sparse ewiseadd bug (cpu)

3 participants