Repository navigation
Conversation
SIM-5391 follow-up. The simmer-sdk skill quick-start rewrite (PR #375) links to runtimes#grok-bot and relies on trading-guide#dry-run covering the place_combo() default — neither existed here yet, so the AI review on #375 flagged a dead link and a dropped safety caveat. - runtimes.mdx: new "Grok Bot" section (anchor #grok-bot) carrying the shared-computer wallet-key warning that used to live inline in the skill's table row. - trading-guide.mdx: Warning block in the "3. Dry run" section noting trade() defaults to dry_run=False while place_combo() defaults to dry_run=True.
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Author
|
Closing as superseded (CTO review, 2026-09-20). main already carries both changes, landed with #169: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for simmer-sdk PR #375 (SIM-5391). The AI review on that PR flagged two dropped-content gaps from the skill quick-start rewrite:
skills/simmer/SKILL.mdlinks toruntimes#grok-bot, but no Grok Bot section existed on this page — dead link, and the wallet-key shared-computer warning that used to be inline in the skill had no docs home.skills/simmer/SKILL.mdpointsplace_combo()'sdry_rundefault caveat attrading-guide#dry-run, but that section never documented thatplace_combo()defaults todry_run=True(opposite oftrade()).Changes
runtimes.mdx: new "Grok Bot" section (anchor#grok-bot) with the shared-computer wallet-key warning, plus a table row pointing at it.trading-guide.mdx:Warningblock in "3. Dry run" documenting thetrade()/place_combo()default mismatch.Tests
Refs SIM-5391