Update to lib so it works#2
Open
simon2000234 wants to merge 3 commits into
Open
Conversation
Also added a link to the timlib github, seems the standard time library in arduino does not have tmElements_t
This check gave a false positive. So i removed it. The clock now works as expected for me. I used an Arduino mega 2560 as board and my clock was DS1374C-33#
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to work with the DS1374C-33# and found this library, however it did not work.
These are the changes i made to make it work for me. I used the arduino mega 2560 as my board and the DS1374C-33# as my clock.
I added some missing return statements and removed a check that did not work.
The biggest change was that i switched from the time.h to timelib.h, this was because tmElements_t was not in time.h but was in timelib.h, i added a link to the timelib github in the readme.md and readme.txt.