Reduce animation loading boilerplate.#9
Open
darrenaustin wants to merge 1 commit intoSpellthorn:masterfrom
Open
Reduce animation loading boilerplate.#9darrenaustin wants to merge 1 commit intoSpellthorn:masterfrom
darrenaustin wants to merge 1 commit intoSpellthorn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks again for the great series. I noticed that there was a lot of unnecessary boilerplate used to load the animations for the Player and Chicken classes. This PR refactors this to remove the unused fields that stores the animations. As they are only ever referenced in the
animationsmap, they are just cluttering up the class. If they are ever needed for something else in the future, they can be pulled from theanimationsmap.In addition it is a good practice to declare the type you are using to specify the animations in the map:
That way the compiler can help you with warnings if you try to use something other than a
PlayerStateforcurrent.