Skip to content

Conversation

@alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Sep 15, 2025

This PR migrates remaining production code from Java to Kotlin.

Other notable changes

  • System property names that were prefixed with flogger. now use the prefix spine.logging..

@alexander-yevsyukov alexander-yevsyukov self-assigned this Sep 15, 2025
@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 69.72477% with 132 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.37%. Comparing base (7655043) to head (6d6880c).
⚠️ Report is 34 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     14.82%   14.37%   -0.46%     
+ Complexity      147      120      -27     
============================================
  Files           102      102              
  Lines          2691     2658      -33     
  Branches        374      377       +3     
============================================
- Hits            399      382      -17     
+ Misses         2262     2245      -17     
- Partials         30       31       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR completes the migration of remaining Java production code to Kotlin, focusing primarily on logging backend and platform implementations. The changes also include a version bump from 2.0.0-SNAPSHOT.400 to 2.0.0-SNAPSHOT.410.

  • Migrated Java logging backend implementations to Kotlin
  • Migrated platform system components from Java to Kotlin
  • Updated version numbers across build files and dependencies

Reviewed Changes

Copilot reviewed 34 out of 35 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
version.gradle.kts Version bump to 2.0.0-SNAPSHOT.410
pom.xml Version bump to 2.0.0-SNAPSHOT.410
platforms/jvm-default-platform/src/test/kotlin/io/spine/logging/backend/system/DefaultPlatformSpec.kt Updated method names from getXxxImpl to doGetXxxImpl for test methods
platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/SystemClock.kt Migrated from Java to Kotlin
platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/StackBasedCallerFinder.kt Migrated from Java to Kotlin
platforms/jvm-default-platform/src/main/kotlin/io/spine/logging/backend/system/DefaultPlatform.kt Migrated from Java to Kotlin
contexts/grpc-context/src/main/kotlin/... Migrated grPC context classes from Java to Kotlin
backends/log4j2-backend/src/main/kotlin/... Migrated Log4j2 backend classes from Java to Kotlin
backends/jul-backend/src/main/kotlin/... Migrated JUL backend classes from Java to Kotlin
dependencies.md Updated timestamps and version references
Files not reviewed (1)
  • .idea/inspectionProfiles/Project_Default.xml: Language not supported

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • .idea/inspectionProfiles/Project_Default.xml: Language not supported

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review September 15, 2025 17:48
Copy link
Contributor

@armiol armiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov LGTM except for a tiny request.

@alexander-yevsyukov alexander-yevsyukov merged commit a6ebcc9 into master Sep 16, 2025
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the migrate-java-code branch September 16, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants