Skip to content

Conversation

@alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Apr 21, 2025

This PR changes the way we declare the dependency on JUnit as a platform.

Previously, we used enforcedPlatform(). This caused the validation error during publishing of the previous PR because we played too hard with the dependency.

Now we changed it to be just platform(), so that projects using TestLib can use newer JUnit versions without waiting for the new version of TestLib, which enforces it.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Apr 21, 2025
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.67%. Comparing base (af04e7d) to head (d477142).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage     60.67%   60.67%           
  Complexity      113      113           
=========================================
  Files            26       26           
  Lines           562      562           
  Branches         20       20           
=========================================
  Hits            341      341           
  Misses          213      213           
  Partials          8        8           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

... simply declare dependency on it as on the platform.
@alexander-yevsyukov alexander-yevsyukov changed the title Fix publishing with platform enforcement Do not enforce JUnit as a platform Apr 22, 2025
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review April 22, 2025 12:40
@alexander-yevsyukov alexander-yevsyukov merged commit 02bfb48 into master Apr 22, 2025
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the fix-publishing-with-platform branch April 22, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants