-
Notifications
You must be signed in to change notification settings - Fork 0
Do not enforce JUnit as a platform #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Update the documentation for `Project.spinePublishing()` block function.
…to fix-publishing-with-platform
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage 60.67% 60.67%
Complexity 113 113
=========================================
Files 26 26
Lines 562 562
Branches 20 20
=========================================
Hits 341 341
Misses 213 213
Partials 8 8 🚀 New features to boost your workflow:
|
... simply declare dependency on it as on the platform.
armiol
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we declare the dependency on JUnit as a platform.
Previously, we used
enforcedPlatform(). This caused the validation error during publishing of the previous PR because we played too hard with the dependency.Now we changed it to be just
platform(), so that projects using TestLib can use newer JUnit versions without waiting for the new version of TestLib, which enforces it.