Introduce GeneratedDirectoryContext
#157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we introduce`GeneratedDirectoryContext`, the `Project.generatedDir` extension is no longer relevant.
... which is used by the Compiler.
| language: String | ||
| ): Path { | ||
| val generatedDir = project.projectDir.resolve(DirectoryName.generated).toPath() | ||
| return generatedDir.resolve("${sourceSet.name}/$language") |
Contributor
Author
There was a problem hiding this comment.
@armiol, as long as the result is Path (not a String), we can have a simplified flow without if branch for an empty language.
armiol
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues unification of the code which customizes
GenerateProtoTasks. In this PR we introduce theGeneratedDirectoryContextinterface which aims to serve as a context parameter when calculating paths to thegenerateddirectory.Before this PR we've had a hard-coded path in the
Project.generatedDirextension value. Now the root directory path comes as a result of theGeneratedDirectoryContext.generatedDir()function.Also the PR brings the code of configuring source sets previously adopted in the Compiler.
Outdated extension properties and functions were removed.
The code was locally tested for building Base.