FIX write order line product link as an integer - #33
Open
Pichinov-Jose wants to merge 1 commit into
Open
Pichinov-Jose wants to merge 1 commit into
Pichinov-Jose wants to merge 1 commit into
Conversation
setValueFrom() is called without a type, so Dolibarr quotes the value and writes an empty string when the product link is cleared. Under MySQL STRICT_TRANS_TABLES the UPDATE is rejected and the line silently keeps its previous product. Passing 'int' makes Dolibarr emit a numeric value. Closes SplashSync#18 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
setValueFrom("fk_product", $productId, "", null, "", "", "none")passes no type, so Dolibarr quotes the value. When the product link is cleared the UPDATE carriesfk_product = "".Under MySQL
STRICT_TRANS_TABLES— the default since 5.7 — that is rejected outright. The query fails, nothing is reported to the source, and the line silently keeps the product it had. The sync reports success while the link is unchanged.Fix
Pass
intas the type so Dolibarr emits a numeric value.Fixes #18. Running in production on a Dolibarr 23.0.0 shop.
🤖 Generated with Claude Code