FIX set both status properties before deleting an order line - #34
Open
Pichinov-Jose wants to merge 1 commit into
Open
Pichinov-Jose wants to merge 1 commit into
Pichinov-Jose wants to merge 1 commit into
Conversation
deleteItem() forces the order back to draft through the deprecated ->statut property. Dolibarr >= 22 reads ->status, so the object still looks validated, deleteline() refuses, and every order line deletion fails. Set both. Closes SplashSync#19 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
deleteItem()forces the order back to draft through$this->object->statut = 0. That property is deprecated: Dolibarr >= 22 reads$this->object->status, which still holds the validated value.deleteline()therefore sees a validated order and refuses, so every order line deletion fails on recent Dolibarr.Fix
Set both properties. One line, and it keeps working on older versions.
Fixes #19. Running in production on a Dolibarr 23.0.0 shop.
🤖 Generated with Claude Code