FIX name the product and the attribute in validation errors - #35
Open
Pichinov-Jose wants to merge 1 commit into
Open
Pichinov-Jose wants to merge 1 commit into
Pichinov-Jose wants to merge 1 commit into
Conversation
An attribute validation failure reported only 'Product Attribute Value Name is Not Valid' — no product, no attribute, no trace of the value received. On a catalogue sync that is a needle in a haystack. Add the product ref and id, the attribute code, and a var_export of the rejected value. Closes SplashSync#20 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
An attribute validation failure reports
Product Attribute Value Name is Not Valid.— and nothing else. Not the product, not the attribute, not the value received.On a one-off that is merely unhelpful. On a catalogue sync it is a needle in a haystack: the operator sees a wall of identical lines and has no way to tell which variant is at fault, nor what the source actually sent.
Fix
Add the product ref and id, the attribute code, and a
var_exportof the rejected value. No behaviour change — only the message.Before:
After:
Fixes #20. Running in production on a Dolibarr 23.0.0 shop.
🤖 Generated with Claude Code