FIX name the reference that failed to create, and who already holds it - #36
Open
Pichinov-Jose wants to merge 1 commit into
Open
Pichinov-Jose wants to merge 1 commit into
Pichinov-Jose wants to merge 1 commit into
Conversation
"Unable to create new Product." says nothing: not which reference, not which label, and above all not which existing product is in the way. Dolibarr also sanitises the reference on create — a "/" becomes "_" — so the ref the source sent and the ref stored differ, and the source retries the same create on every sync without anyone being able to find the culprit. Report the ref and label, and look up the conflicting product under both the raw and the sanitised form. Closes SplashSync#22 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Unable to create new Product.— that is the whole message. Not the reference, not the label, and above all not which existing product is in the way.It gets worse: Dolibarr sanitises the reference on create (
dol_sanitizeFileName(dol_string_nospecial(...)), so/becomes_). The reference the source sent and the reference stored are then different, the source never finds its product on the next sync, tries to create it again, and fails again. An endless create loop that nothing in the log explains.Fix
Report the ref and the label, and look up the conflicting product under both the raw and the sanitised form.
Before:
After:
Fixes #22. Running in production on a Dolibarr 23.0.0 shop.
🤖 Generated with Claude Code