FIX refuse to delete a variant parent product - #37
Open
Pichinov-Jose wants to merge 1 commit into
Open
Pichinov-Jose wants to merge 1 commit into
Pichinov-Jose wants to merge 1 commit into
Conversation
load() already refuses to open a variant parent, but delete() has no such guard. A parent carries no order line of its own, so isObjectUsed() believes it is free and Dolibarr deletes it together with every variant hanging from it — a whole family lost on a single delete instruction from the source. Apply the same guard as load(). Closes SplashSync#23 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
load()already refuses to open a variant parent (ProductIsVariantBase).delete()has no such guard.A parent carries no order line of its own, so
isObjectUsed()believes it is free, andProduct::delete()removes it together with every variant hanging from it. One delete instruction from the source, and a whole family is gone — including variants that are used on real orders.Fix
Apply the same guard as
load(), at the top ofdelete()before anything is fetched.Fixes #23. Running in production on a Dolibarr 23.0.0 shop.
🤖 Generated with Claude Code