Skip to content

FIX keep the variation attribute value when a custom attribute shadows a taxonomy #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pichinov-Jose wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX keep the variation attribute value when a custom attribute shadows a taxonomy #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Objects/Product/Variants/AttributesTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,19 @@ private function getVariantsAttributesField(string $fieldId, string $code, strin
// Load Attribute
$attribute = Manager::getValueByCode($code, $name);
$attributeName = $attribute->name ?? "";
//====================================================================//
// Group found, value not resolved: fall back on the raw value.
//
// The variation carries a custom attribute (attribute_xxx) while a
// taxonomy of the same name (pa_xxx) exists. getValueByCode() looks the
// value up in the taxonomy, finds nothing, and the name comes back
// empty — so the variation is exported with no value at all, and
// targets that require one reject the whole product.
//
// The raw value the variation actually holds is the right answer here.
if (!$attribute) {
$attributeName = $name;
}

//====================================================================//
// Read Mono-lang Values
Expand Down