Legacy-Cleanup after Blueprint-Rework

[DaniloTatti]

User Story

As the AI/backend team, I want the orphaned onboarding generation routes and
their modules removed, so that nobody reads, extends, or accidentally calls AI
endpoints that no backend flow uses anymore.

Context & Motivation

• Type: Technical debt / cleanup
• Parent epic: 06 EPIC - Onboarding Journey & Digital Adoption #55
• Concept: industry-detection-concept.md §6.2/§6.3
• Builds on: the blueprint rework (backend [Story]: Vibe Coding — shared guidelines, tips & best practices (cross-team + per-repo) #223, AI .env.example per repo + root #192) and the industry
  re-anchoring story ([Story]: Industry detection — consumer chain (onboarding path, re-anchored) #296).
• Why: after the blueprint rework, OnboardingPersonalizationService
  personalizes by copying the project's active blueprint and filling only
  AI_ENHANCED phases via POST /onboarding/phase[/stream]. The old
  /onboarding/path (PersonProfile → pipeline → synthesis) and
  /onboarding/blueprints/generate (blueprint drafting) routes therefore have
  no callers left. The industry-detection concept deliberately does not
  re-anchor anything onto them (£6.2/£6.3, marked obsolete). Keeping them means
  dead prompts, dead tests, and a standing invitation to build against the wrong
  AI edge.

In Scope (verify before deleting — each AC names its evidence)

• Audit callers first: grep backend (Kotlin) for calls to
  /onboarding/path, /onboarding/path/yaml, /onboarding/blueprints/generate;
  confirm zero remaining callers after [Story]: Vibe Coding — shared guidelines, tips & best practices (cross-team + per-repo) #223/[Story]: Industry detection — consumer chain (onboarding path, re-anchored) #296 (AI route files are
  api/routes/onboarding.py and api/routes/blueprints.py).
• Remove api/routes/onboarding.py (POST /onboarding/path,
  POST /onboarding/path/yaml) from the AI service and unregister the router in
  api/app.py.
• Remove api/routes/blueprints.py (POST /onboarding/blueprints/generate)
  and unregister it in api/app.py.
• Remove modules that become orphaned as a result — candidates to verify:
  onboarding/orchestrator.py, onboarding/pipeline.py,
  onboarding/synthesis.py, onboarding/generation.py (blueprint drafting only),
  onboarding/registry.py, onboarding/similarity.py (only if no other module
  imports them). Keep everything the phase assembly still needs
  (onboarding/phase.py, phase_models.py, citations.py, retrieval/rag, …).
• Remove/adjust the corresponding schemas (OnboardingPathRequest,
  GenerateBlueprintsRequest, and any schema only they use) from
  api/schemas.py, unless still referenced.
• Delete or migrate the now-orphaned tests
  (tests/onboarding/test_pipeline.py, test_synthesis.py,
  test_generation.py, tests/api/test_onboarding.py (path parts),
  tests/api/test_blueprints.py — keep any parts covering /onboarding/phase).
• Never touch: /api/v1/onboarding/phase[/stream], the ingestion routes,
  the backend's OnboardingPersonalizationService contract, and any schema the
  backend still sends.

Acceptance Criteria

• No code references to the removed routes remain (app.py registration
  removed, no imports).
• pyright src/ has 0 errors; no dead imports.
• ruf check / pytest green with the removed tests deleted; no test still
  hits a removed endpoint.
• The backend suite is unaffected (no backend change required — verify by
  running its tests against the AI service's updated contract, if locally available).
• The repo's OpenAPI no longer lists /onboarding/path,
  /onboarding/path/yaml, or /onboarding/blueprints/generate.

Technical Notes

• Do this after [Story]: Industry detection — consumer chain (onboarding path, re-anchored) #296 (industry re-anchoring) has merged, so the "one live
  AI-writing edge" statement in the concept matches the code on the same day.
• If a module turns out to still have a caller (e.g. a leftover frontend/backend
  flow), stop and report instead of deleting.

Sub-Tasks (by team)

• AI — caller audit, route/module removal, test cleanup, verification.