Support optional project context in skill suggestion (#299) - #202
Merged
Merged
Conversation
Afif-del
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes part of SprintStartProject/Wiki#299 (Skill suggestion integration).
Relaxes the
projectIdrequirement onPOST /api/v1/skills/suggestso roles without project scoping (person-level / global roles) can request AI skill suggestions.Changes
src/api/schemas.py):SkillSuggestionRequestnow inheritsBaseModeldirectly and makesproject_id: ProjectId | None = Field(default=None, alias="projectId")optional.src/skills/suggestion.py):suggest_skillsacceptsproject_id: str | None = None.hybrid_retrieveonly runs whenproject_id is not None and store.count() > 0. Whenproject_idis absent, retrieval is skipped (preserving fail-closed scoping against cross-project retrieval).tests/skills/test_suggestion.py: asserts retrieval is skipped and zero store queries happen whenproject_id=None.tests/api/test_skills.py: end-to-end API test verifyingPOST /api/v1/skills/suggestsucceeds with 200 withoutprojectIdand returns universal suggestions.