Skip to content

Notion connector - #217

Merged
kiranfin merged 2 commits into
devfrom
notion-connector
Oct 6, 2026
Merged

kiranfin merged 2 commits into
devfrom
notion-connector

Conversation

@kiranfin

@kiranfin kiranfin commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Short summary

Accept NOTION as a source system in the AI service, so chunks ingested from the Notion connector keep their source system and can be filtered in chat.

  • Added NOTION to the SourceSystem literal and to is_source_system in src/rag/types.py, so Notion chunks are no longer rejected or dropped during ingestion.
  • Added NOTION to SourceSystemValue in src/api/schemas.py, so the chat request filter accepts it.
  • Added tests for the ingest round trip, the case-insensitive normalization and the chat filter (tests/rag/test_filters.py, tests/api/test_chat.py).

Checks

  • I verified the code makes sense intuitively
  • The PR changes affect only this issue, no unrelated/unwanted code changes to other modules/code segments
  • CI runs (./gradlew clean build, keycloack)
  • New business logic is unit tested, including WebMvcTest for api controllers
  • The new functionality is tested manually

- Add NOTION to the chat filter values and the known source systems so Notion chunks keep their source system
- Cover the ingest round trip, the case-insensitive normalization and the chat filter in tests
- Resolve the source system conflicts so BITBUCKET and NOTION are both accepted
- Keep the Bitbucket tests from dev and the Notion tests side by side
@kiranfin
kiranfin merged commit 3a31161 into dev Oct 6, 2026
4 checks passed
@kiranfin
kiranfin deleted the notion-connector branch October 6, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants