The review of PR #250 (the #207 cleanup) flagged that nothing enforces format:check in CI: Node.js CI runs npm ci → lint → build → unit → a11y → docker build, but not npm run format:check. Prettier drift therefore reaches dev silently — it did, which is why #207/#250 exist.
Suggested: add npm run format:check as a step in the build job (~10 s), or fold it into an existing gate. Until then, format-only regressions rely on local discipline.
Found while reviewing PR #250. Another instance of the same gap: quoteFormat.ts drift on the chat stack (fixed in PR #225, commit d904e33) shipped because CI never checks formatting.
The review of PR #250 (the #207 cleanup) flagged that nothing enforces
format:checkin CI:Node.js CIrunsnpm ci→ lint → build → unit → a11y → docker build, but notnpm run format:check. Prettier drift therefore reaches dev silently — it did, which is why #207/#250 exist.Suggested: add
npm run format:checkas a step in the build job (~10 s), or fold it into an existing gate. Until then, format-only regressions rely on local discipline.Found while reviewing PR #250. Another instance of the same gap: quoteFormat.ts drift on the chat stack (fixed in PR #225, commit d904e33) shipped because CI never checks formatting.