Repository navigation
fix(buddy): say what actually disables the new-conversation control - #319
Merged
Merged
Conversation
Three doc blocks still described the round before the mid-answer stop: the new-conversation button's header said it is disabled mid-turn because newConversation "cannot call back a request already streaming into it", and the conversation list's prop doc and binning paragraph said picking or binning mid-turn is refused and the controls stand down for that window. None of that is true anymore — the move stops the running answer itself (see `stopRunningTurn`) and stays on offer mid-answer; the list is disabled only for an open, a greeting, or a decision in flight (and in team mode), never for a running answer. - The button's header now lists the caller's actual disable terms: team mode, empty conversation, an open or greeting in flight, a proposal decision in flight — and says mid-answer it stays live. - The list's prop doc matches the caller's condition and points at stopRunningTurn for what happens to a running answer. - The binning paragraph now says the session stops a reply still streaming into the conversation being binned, and leaves a running answer in another conversation alone. Comment-only; no behavior change.
kiranfin
approved these changes
Oct 7, 2026
daniilperkin
added a commit
that referenced
this pull request
Oct 7, 2026
…fixes fix: sprint 10 release-audit findings (stacked on #319)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three doc blocks still described the round before the mid-answer stop. The new-conversation button's header said it is disabled mid-turn because
newConversation"cannot call back a request already streaming into it", and the conversation list's prop doc plus its binning paragraph said picking or binning mid-turn is refused and the controls stand down for that window. None of that is true anymore — the move stops the running answer itself (seestopRunningTurn) and stays on offer mid-answer; the list is disabled only for an open, a greeting, or a decision in flight (and in team mode), never for a running answer.Changes
BuddyNewConversationButton— the header now lists the caller's actual disable terms (team mode, empty conversation, an open or greeting in flight, a proposal decision in flight) and says mid-answer it stays live.BuddyConversationList— thedisabledprop doc matches the caller's condition and points atstopRunningTurnfor what happens to a running answer; the binning paragraph now says the session stops a reply still streaming into the conversation being binned, and leaves a running answer in another conversation alone.Comment-only; no behavior change.
Verification
prettier --check+eslinton the two touched files — passnpm run build— passvitest runon the suites covering the touched files (BuddyConversationList,BuddyPage,BuddyPage.address,BuddyPagea11y) — passNotes
Found in the post-merge audit of the buddy-surface PRs (#318 frontend side).
hotfix/branch, targetsdev.