Skip to content

fix(buddy): say what actually disables the new-conversation control - #319

Merged
kiranfin merged 1 commit into
devfrom
hotfix/buddy-audit-fixes
Oct 7, 2026
Merged

kiranfin merged 1 commit into
devfrom
hotfix/buddy-audit-fixes

Conversation

@daniilperkin

Copy link
Copy Markdown
Collaborator

What

Three doc blocks still described the round before the mid-answer stop. The new-conversation button's header said it is disabled mid-turn because newConversation "cannot call back a request already streaming into it", and the conversation list's prop doc plus its binning paragraph said picking or binning mid-turn is refused and the controls stand down for that window. None of that is true anymore — the move stops the running answer itself (see stopRunningTurn) and stays on offer mid-answer; the list is disabled only for an open, a greeting, or a decision in flight (and in team mode), never for a running answer.

Changes

  • BuddyNewConversationButton — the header now lists the caller's actual disable terms (team mode, empty conversation, an open or greeting in flight, a proposal decision in flight) and says mid-answer it stays live.
  • BuddyConversationList — the disabled prop doc matches the caller's condition and points at stopRunningTurn for what happens to a running answer; the binning paragraph now says the session stops a reply still streaming into the conversation being binned, and leaves a running answer in another conversation alone.

Comment-only; no behavior change.

Verification

  • prettier --check + eslint on the two touched files — pass
  • npm run build — pass
  • vitest run on the suites covering the touched files (BuddyConversationList, BuddyPage, BuddyPage.address, BuddyPage a11y) — pass

Notes

Found in the post-merge audit of the buddy-surface PRs (#318 frontend side). hotfix/ branch, targets dev.

Three doc blocks still described the round before the mid-answer stop:
the new-conversation button's header said it is disabled mid-turn
because newConversation "cannot call back a request already streaming
into it", and the conversation list's prop doc and binning paragraph
said picking or binning mid-turn is refused and the controls stand
down for that window. None of that is true anymore — the move stops
the running answer itself (see `stopRunningTurn`) and stays on offer
mid-answer; the list is disabled only for an open, a greeting, or a
decision in flight (and in team mode), never for a running answer.

- The button's header now lists the caller's actual disable terms:
  team mode, empty conversation, an open or greeting in flight, a
  proposal decision in flight — and says mid-answer it stays live.
- The list's prop doc matches the caller's condition and points at
  stopRunningTurn for what happens to a running answer.
- The binning paragraph now says the session stops a reply still
  streaming into the conversation being binned, and leaves a running
  answer in another conversation alone.

Comment-only; no behavior change.
@kiranfin
kiranfin merged commit bd3ba04 into dev Oct 7, 2026
4 checks passed
@daniilperkin
daniilperkin deleted the hotfix/buddy-audit-fixes branch October 7, 2026 11:00
daniilperkin added a commit that referenced this pull request Oct 7, 2026
…fixes

fix: sprint 10 release-audit findings (stacked on #319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants