Fix instance part alpha fading not applying#199
Merged
Conversation
7c0f41f to
1bb6274
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原因
Instanceパーツのアルファ値(不透明度)が Godot 側の
CanvasItemに反映されておらず、SpriteStudio 側で設定したインスタンスパーツのフェードアウトが Godot 上で反映されない(不透明のまま見え続ける)不具合がありました。修正内容
ss_internal_player.cppの_emit_instance_slotにおいて、パーツ自身のalpha値を取得し、Godot のcanvas_item_set_modulateを使用して設定するよう処理を1行追加しました。これにより、子インスタンス全体に親の不透明度が正しく乗算されるようになります(SSPlayerForUnity等における事前合成アプローチと同等の結果になります)。また、使い捨ての CanvasItem への設定であるため副作用もありません。