feat(evaluation): add agent-confirmed PointNav evaluation - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implement roadmap PR 09 with a deterministic PointNav evaluator, while correcting two architecture gaps discovered during implementation:
Scope
AgentTaskStateROS contract withIDLE,RUNNING,SUCCEEDED, andFAILEDstates.SUCCEEDED.rh_bringupas the sole concrete Experiment-container composition root.Out of scope
Architecture changes
The final success decision now uses two signals:
SUCCEEDED;Passing through the goal without Agent completion no longer terminates the Episode. Agent failure, simulation-time timeout, infrastructure failure, and operator abort remain distinct termination paths.
rh_experimentremains implementation-independent and exposes Task/Evaluator factory boundaries.rh_bringupis the only package that imports concrete implementations and currently provides the reviewedpointnav_simpleassembly.Implementation
AgentTaskState.ros2 run rh_bringup experiment --profile pointnav_simple.Testing
git diff --check: passed.rh_bringup experimentis exposed for the central runtime./clockhandling.Acceptance criteria
Known limitations
Follow-up