Repository navigation
qt: refresh Ord index after new blocks - #2
Closed
Joopooranski wants to merge 4 commits into
Closed
Joopooranski wants to merge 4 commits into
Joopooranski wants to merge 4 commits into
Conversation
14 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to bitcoindogmode#12 and my Ord index lifecycle review. The current GUI starts
ord index updateonce and stops its synchronization timer. Because the command exits, later blocks remain unindexed until Bitcoin Qt restarts.Keep the 30-second timer running, track the Bitcoin best-block hash, and run another Ord update when the tip changes, including a same-height reorganization. Skip checks while Ord is already indexing and show the initial success notification only once. Document this behavior in
doc/ord.md.Validation:
git diff --checkpassed. The changedbitcoin.cpp.oandordmanager.cpp.ocompiled on Ubuntu 24.04 with Qt 6.4.2 in a wallet-disabled GUI configuration that also included the separate Qt Network fix from #1. A fulltest_bitcoin-qtlink failed locally with unresolved symbols in the build; I have not run a GUI end-to-end test of automatic refresh. This follow-up needs runtime review before merge.