Support transfers for layouts with multiple id-indexed fields - #284
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 29.07% 29.20% +0.12%
==========================================
Files 194 195 +1
Lines 40229 40493 +264
Branches 14458 14693 +235
==========================================
+ Hits 11697 11826 +129
- Misses 27598 28242 +644
+ Partials 934 425 -509 ☔ View full report in Codecov by Sentry. |
a1c10a5 to
ed1820b
Compare
|
@2dm Thanks for adding this PR to the github. What's our strategy here? Are you proposing to carry it through the review process or do we plan to split it up? |
|
@2dm The OG gitlab CI was passing for all tests (except clang-format): It's either some regression with the additional changes we make to reduce copy launch overhead or there are different settings/tests in github CI compared to gitlab. |
917b308 to
3bca93c
Compare
3bca93c to
9e84214
Compare
c032b92 to
06e5ba4
Compare
9e84214 to
9a0df71
Compare
06e5ba4 to
792909a
Compare
9a0df71 to
6ab1e8a
Compare
6cc0068 to
aff2822
Compare
Co-authored-by: apriakhin <apriakhin@nvidia.com>
Co-authored-by: apriakhin <apriakhin@nvidia.com>
d71688e to
47d7e74
Compare
|
overall LGTM, left just one comment |
15359ca to
722811f
Compare
This patch adds a fast‐path for multi‐field copies when source and destination instances store fields consecutively in memory with strictly increasing IDs. Instead of the generic per‐field iterator, Realm switches to an IDIndexedIterator and issues the entire copy as a single batched DMA operation.
Fast‐Path Mechanics
Testing
Authored by @apryakhin