Add rsrv logger for machine topology - #459
Open
elliottslaughter wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
=======================================
Coverage ? 29.99%
=======================================
Files ? 196
Lines ? 40906
Branches ? 14801
=======================================
Hits ? 12268
Misses ? 28184
Partials ? 454 ☔ View full report in Codecov by Harness. |
Contributor
|
Can we name it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458.
Adds a new
-level rsrv=2logger that replaces-ll:show_rsrv. Right now the old code paths are still in place, and this new code path works independently of the old flag. Use-level rsrv=2OR-ll:show_rsrv, not both.Alternatives/design decisions:
-ll:show_rsrvin favor of the new logger, possibly with an error message to users who attempt to use it, directing to the new syntax.Output looks like: