Fix GASNetEx Injector Quiescence Race - #470
Open
lightsighter wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
========================================
Coverage 30.41% 30.41%
========================================
Files 199 199
Lines 41282 41282
Branches 14810 14783 -27
========================================
Hits 12554 12554
+ Misses 27759 27398 -361
- Partials 969 1330 +361 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a GASNet-EX shutdown race caused by tracking concurrent injector workers with a boolean. When one worker finished before another, it could clear work_active prematurely, allowing network quiescence to be reported while an xpair was still in use.
Replace the boolean with an active-worker counter so every concurrent push_packets() invocation remains visible to quiescence detection.