Bug in ExpressionDark.xaml - Radio Button Template#3
Open
mwallnoefer wants to merge 4 commits intoStanislawSwierc:masterfrom
Open
Bug in ExpressionDark.xaml - Radio Button Template#3mwallnoefer wants to merge 4 commits intoStanislawSwierc:masterfrom
mwallnoefer wants to merge 4 commits intoStanislawSwierc:masterfrom
Conversation
added 4 commits
October 5, 2015 16:16
The radio button's initial opacity needs to be set to 1, not 0. Otherwise the bullet is not shown on the initially selected entry, only after the first change. The bug is also mentioned in the MSDN forum: https://social.msdn.microsoft.com/Forums/vstudio/en-US/c1aa5e04-bf61-4f37-9ca4-7cf1866c5ea8/the-bullet-in-a-radiobutton-becomes-invisible-after-applying-a-new-theme-at-runtime-via?forum=wpf&prof=required
This comes handy in various situations.
If the list box item is large and the text label short I noticed that the click-able area was limited to the text bounds. This should not be the case since the whole ListBoxItem area including the blank area should be responsive. Example: |xxxxxx |
In this case ShadeBrush seems more appropriate than NormalBrush, also to notice the difference between the hover behaviour.
Author
|
Any news on this? |
Owner
|
@mwallnoefer Thank you for the contribution! It's been a while since I did some work on this project. I will look into your change this weekend and include it in the new NuGet package after I confirm it is good. |
Author
|
Any news on this? |
Owner
|
I apologize, but I'm not confident in reviewing this pull request as my WPF skills are quite rusty. It's been over a decade since I last worked with this technology, and I don't feel equipped to provide a thorough review. Ideally, I would have reviewed it earlier, but at this point, I think the best options would be to either fork the project or transfer ownership to someone more familiar with WPF. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The radio button's initial opacity needs to be set to 1, not 0. Otherwise the bullet is not shown on the initially selected entry, only after the first change.
The bug is also mentioned in the MSDN forum: https://social.msdn.microsoft.com/Forums/vstudio/en-US/c1aa5e04-bf61-4f37-9ca4-7cf1866c5ea8/the-bullet-in-a-radiobutton-becomes-invisible-after-applying-a-new-theme-at-runtime-via?forum=wpf&prof=required