Open
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable Kubernetes Ingress resource to the starrocks Helm subchart (and mirrors the configuration into the parent kube-starrocks chart), intended to expose StarRocks FE externally without using a LoadBalancer Service.
Changes:
- Added
ingressconfiguration blocks to both the parent and subchartvalues.yaml. - Introduced a new
templates/ingress.yamlthat renders anetworking.k8s.io/v1Ingress when enabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| helm-charts/charts/kube-starrocks/values.yaml | Adds parent-chart passthrough values for the new ingress feature. |
| helm-charts/charts/kube-starrocks/charts/starrocks/values.yaml | Adds subchart ingress values (enabled flag, className, rules, TLS, service target). |
| helm-charts/charts/kube-starrocks/charts/starrocks/templates/ingress.yaml | Adds an Ingress template that creates HTTP rules pointing to the FE service. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
kevincai
reviewed
Mar 27, 2026
…rRocks#739) * add waitForFullRollout option for safer rolling upgrades Signed-off-by: AdheipSingh <adheip1222@gmail.com> * add logging for FE readiness checks and test for nil replicas Signed-off-by: AdheipSingh <adheip1222@gmail.com> --------- Signed-off-by: AdheipSingh <adheip1222@gmail.com> Signed-off-by: CG <cgpoh76@gmail.com>
…off (StarRocks#744) Signed-off-by: Kevin Cai <kevin.cai@celerdata.com> Signed-off-by: CG <cgpoh76@gmail.com>
Signed-off-by: CG <cgpoh76@gmail.com>
…SQL service Signed-off-by: CG <cgpoh76@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since we are not exposing the service via a LoadBalancer and instead rely on an Ingress controller to route traffic to the StarRocks service, an Ingress template is required.
Related Issue(s)
N/A
Checklist
For operator, please complete the following checklist:
For helm chart, please complete the following checklist:
file of starrocks chart.
scriptsdirectory, runbash create-parent-chart-values.shto update the values.yaml file of the parentchart( kube-starrocks chart).