update management permission regex - #26
Open
Toumash wants to merge 1 commit into
Open
Conversation
Toumash
force-pushed
the
bugfix/management-api-exclude-from-needing-permissions
branch
from
December 2, 2021 20:46
ffad6c8 to
8022a05
Compare
Author
|
Writing the test in the yarn test
yarn run v1.22.17
$ cross-env TS_NODE_COMPILER_OPTIONS={\"module\":\"commonjs\"} mocha --file tests/unit/setup.ts --require ts-node/register --require tsconfig-paths/register
TSError: ⨯ Unable to compile TypeScript:
src/utils/helpers.ts:84:25 - error TS2571: Object is of type 'unknown'.
84 handleError(error.message); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue with details can be found here: #22
New regex for checking if code is using the management module
There is something more missing, because adding this code to
examples\background\dist\background.jsand running the build
still adds
managementintoexamples\background\dist\manifest.jsonI'm still unsure how exactly code in file
src\manifest-input\manifest-parser\permissions.tsis being used