fix: keep flag at /store.json so upgraders don't get another notification (0.11.1:7)#69
Closed
helix-nine wants to merge 1 commit into
Closed
fix: keep flag at /store.json so upgraders don't get another notification (0.11.1:7)#69helix-nine wants to merge 1 commit into
helix-nine wants to merge 1 commit into
Conversation
…tion (0.11.1:7) 0.11.1:6 moved the sync-notified flag from /store.json (field `syncNotified`) to /sync-notified.json (field `notified`). On upgrade to :6 the new file wouldn't exist, the closure flag would default to false, and the user would get one more Sync Complete notification right after the index check passes. Match the pre-:6 on-disk shape: keep the file model named storeJson but point it back at /store.json with the `syncNotified` field. Existing upgraders' `syncNotified: true` is honored straight through, no extra notification fires. Closure-flag pattern is preserved. Bumps 0.11.1:6 → 0.11.1:7, renamed in place; the prior config.yaml → toml migration is carried unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #68. That PR fixed the re-fire bug correctly, but moved the on-disk flag from
/store.json(syncNotified) to/sync-notified.json(notified). On upgrade to :6 the new path wouldn't exist, the closure flag would default tofalse, and the user would get one more Sync Complete notification the first time the index probe passed — exactly what we're trying to avoid.Rename the file model back to point at
/store.jsonwith fieldsyncNotified(matching the pre-:6 on-disk shape). Existing upgraders'syncNotified: trueis read straight through, no extra notification fires. Closure-flag pattern from :6 is preserved.Bumps 0.11.1:6 → 0.11.1:7, renamed in place; the prior
config.yaml → tomlmigration is carried unchanged.Test plan
npm run checkcleanmake x86buildselectrs_x86_64.s9pkv0.11.1:7syncNotified: truein/store.json; confirm no Sync Complete notification fires on upgrade