fix: 31.0:13 — IPC socket crash loop in nocow oneshot (#222)#223
Merged
Conversation
The nocow oneshot ran `chattr -R +C` over the entire data directory. `chattr` returns "Operation not supported" on Unix socket files, which aborted the oneshot with a non-zero exit code and put the package into a restart loop whenever bitcoin-core.sock was left behind in $rootDir/ipc/ (issue #222). Restrict the recursive chattr to directories and regular files via `find`, and remove any stale IPC socket up front so bitcoin-node can bind cleanly. Bumps to 31.0:13.
3b4de90 to
1c06091
Compare
MattDHill
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitcoin-core.sockin$rootDir/ipc/hit a restart loop: thenocowoneshot'schattr -R +C $rootDirreturns "Operation not supported" on Unix socket files and exits non-zero, aborting startup.chattr +Cto directories and regular files viafind … \( -type d -o -type f \) -exec chattr +C {} +, and remove any stale IPC socket up front so bitcoin-node can bind cleanly.Note: 28.x / 29.x / 30.x don't ship IPC, so they can't produce the stale socket and aren't affected. The
find -type d -o -type fchange is a robustness improvement that could be backported defensively, but isn't required to fix this bug.Test plan
npx tsc --noEmitcleanmakebuilds successfully (riscv64 + x86_64, v31.0:13)bitcoin-core.sockin$rootDir/ipc/and confirm bitcoind starts instead of crash-looping