Repository navigation
chore: move to start-sdk 3.0.3; 6.67.0:0 → 6.67.0:1 - #47
Merged
Merged
Conversation
- pin @start9labs/start-sdk 3.0.3, regenerate the lock from scratch, drop the toolchain devDependencies and scripts the SDK supplies, use the SDK's shared prettier config - store.json model is z.looseObject at every level, without .strip() - empty sdk.Dependencies.of() builder, passed to buildManifest and setupInit - Set Primary Url is sdk.setupPrimaryUrl with fallback: false, keeping its action id and env.url: a critical task raised while no address is chosen or its hostname is gone, an empty form, and main refusing to start without a URL; a port-only change is followed - Primary and Admin UI nominate the primary URL as preferredLauncherAddress - Enable/Disable Tinfoil Mode and Reset Owner Password warn before running - Configure SMTP's description no longer claims Ghost receives email - release notes keep 6.67.0:0's notes - sync workflows and AGENTS.md boilerplate to the package template; update README and instructions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
helix-a
approved these changes
Oct 8, 2026
helix-a
left a comment
Member
There was a problem hiding this comment.
Reviewed the SDK 3.0.3 migration, primary-URL/action/task integration, file-model changes, and package documentation at 369ad47. No correctness regressions found. Merge-tree and diff-whitespace checks pass; SDK pin matches npm latest. Reused successful exact-head CI covering TypeScript, formatting, bundling, and x86_64/aarch64 packing. Runtime testing not performed.
Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK 3.0.3 migration, with Set Primary Url on the SDK helper and the confirmations it calls for.
npm audit0). The toolchain the SDK now supplies is dropped, and.prettierrcnames the SDK's shared config.store.jsonisz.looseObject, and its.strip()is gone, so a key written by hand or by a later version survives the next write.sdk.Dependencies.of()builder, passed tobuildManifestandsetupInit.sdk.setupPrimaryUrlwithfallback: false. Same action id and the same storedenv.url, so existing choices carry over. Ghost never runs on an address the user didn't choose, because published links and the admin login are built from it:criticaltask is raised while no URL is chosen or its hostname is no longer published, andmain.tsrefuses to start without one. A fresh install now asks for the URL, with nothing preselected, instead of silently taking the.localaddress.preferredLauncherAddress; admin login only works there.6.67.0:0's upstream notes above this revision's bullets..localaddress was disabled at install time started with an empty URL and no task; it now gets the task.ready_for_review,pr-retarget.yml);AGENTS.md, README and instructions updated.🤖 Generated with Claude Code