Skip to content

perf: report a daemon that is not ready yet as starting - #51

Merged
MattDHill merged 1 commit into
masterfrom
perf/ready-starting
Oct 16, 2026
Merged

MattDHill merged 1 commit into
masterfrom
perf/ready-starting

Conversation

@MattDHill

@MattDHill MattDHill commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

A daemon ready check that isn't satisfied yet now returns starting instead of loading, in the MySQL sidecar check. The "Initializing fresh schema" state stays loading: it is long-running progress with a message the UI shows for loading and hides for starting.

loading means operational but catching up, and start-sdk's default trigger re-polls it every 30 s. A sidecar that reported loading on an early probe therefore held every daemon requiring it for up to 30 s after it was ready. starting is re-polled every second. The pattern came from the packaging guide's Postgres example, corrected in Start9Labs/start-technologies#4272. Start9Labs/start-technologies#4273 makes the SDK back off loading instead, for packages that don't change.

No version bump: master's 6.71.0:0 isn't on beta yet, so this ships with it. Its release notes gain "Performance improvement", placed before the upstream link.

Per helix-a's review, README's first-run notes now describe MySQL as starting until it accepts queries, and Ghost's schema creation as loading.

Verified: tsc --noEmit, Prettier and make javascript/index.js pass. Not installed on a box.

🤖 Generated with Claude Code

@MattDHill
MattDHill requested a review from helix-a October 16, 2026 17:58

@helix-a helix-a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readiness change itself looks correct. One documentation correction is needed: README.md's Installation and First-Run Flow still says both startup checks report loading with explanatory messages throughout. MySQL now reports starting; the proposal updates that sentence and preserves Ghost's schema-initialization loading description. instructions.md does not describe these states and needs no change.

Verified: clean merge with origin/master via merge-tree; SDK 3.0.6 matches npm's latest; beta serves 6.70.0:0 and does not yet serve 6.71.0:0, so keeping the version is appropriate. Ran npm install, tsc --noEmit, Prettier on the changed TypeScript files, and git diff --check. Reused successful x86 and arm package-build CI for head 00eb9ab. No runtime testing performed.

Proposed changes: 00eb9ab...proposal/51

Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol

A ready check that returns `loading` while its daemon is still coming up
is re-polled every 30 s under start-sdk's default trigger, so every
daemon that requires it waits up to 30 s after it is actually ready.
`starting` is re-polled every second.

README's first-run notes describe MySQL as starting and Ghost's schema creation as loading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MattDHill
MattDHill force-pushed the perf/ready-starting branch from 00eb9ab to 6b6373b Compare October 16, 2026 18:19
@MattDHill
MattDHill requested a review from helix-a October 16, 2026 18:21

@helix-a helix-a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README correction resolves my earlier request: it now distinguishes MySQL's starting state from Ghost's schema-initialization loading state. The updated tree exactly matches the previously verified proposal; no further findings.

Rechecked mergeability with origin/master using merge-tree, git diff --check, SDK 3.0.6 against npm's latest, and that beta still does not serve 6.71.0:0. Both x86 and arm package-build CI jobs passed on the new head 6b6373b. Reused the earlier successful typecheck and changed-TypeScript formatting checks; the only follow-up change is documentation. No runtime testing performed.

Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol

@MattDHill
MattDHill merged commit cbf6fc9 into master Oct 16, 2026
4 checks passed
@MattDHill
MattDHill deleted the perf/ready-starting branch October 16, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants