Release 3.3.1:3 — internal updates (start-sdk 1.5.0)#53
Closed
helix-nine wants to merge 1 commit into
Closed
Conversation
- Bump @start9labs/start-sdk 1.3.3 → 1.5.0 - Cast bitcoind autoconfig action to any in createTask: bitcoin-core-startos still pins start-sdk 1.3.x, so its Action type is a distinct module instance from ours and TS infers GetActionInputType as never. Drop the cast once the sibling bumps. - Drop docsUrls from manifest (removed from SDKManifest in 1.5.0). - npm update — refresh git-pinned sibling deps (bitcoin-core-startos, cln-startos, lnd-startos) to current master.
Member
|
Duplicate of #52 from the earlier monitor batch; closing this one. |
Contributor
Author
|
Acknowledged — #52 is the live one for the SDK 1.5.0 bump. Thanks for the cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine maintenance bump. Mempool's last release (
3.3.1:2) was on start-sdk 1.3.3; this catches up to 1.5.0, refreshes git-pinned sibling deps to current master, and adapts to the SDK's manifest cleanup. Upstream Mempool is unchanged at v3.3.1.Changes
startos/dependencies.ts— Castautoconfigtoanyin the cross-packagesdk.action.createTask(..., 'bitcoind', autoconfig, ...)call. bitcoin-core-startos still pins start-sdk 1.3.x, so itsAction<...>type is a distinct module instance from our 1.5.x — structurally identical but TS infersGetActionInputTypeasneverthrough it (the underlying difference isEffectsgainingnotificationin 1.5.0, which breaksAction's structural compatibility across versions). Drop the cast once bitcoin-core-startos bumps. This matches the pattern btcpayserver-startos uses for the same situation with monerod-startos.startos/manifest/index.ts— DropdocsUrls; field was removed fromSDKManifestin 1.5.0. The upstream docs link is still surfaced via the README header.npm update— refreshes bitcoin-core-startos / cln-startos / lnd-startos pins to currentmaster.3.3.1:2→3.3.1:3(rename in place per convention; existing 0.3.5.1 → 3.3.x migration unchanged).Test plan
npx tsc --noEmit— passesmake— bothmempool_x86_64.s9pkandmempool_aarch64.s9pkbuild cleanly