Conversation
- @start9labs/start-sdk 1.3.3 → 1.5.0 - Cast bitcoin-core-startos's autoconfig Action to our SDK's Action interface — sibling packages are still on 1.3.3, and 1.5.0 added effects.notification which makes structural Action matching fail in createTask's GetActionInputType inference (input value narrows to never). Cast restores the input type. - Refresh bitcoin-core-startos / cln-startos / lnd-startos pinned commits to current master HEADs. npm update is blocked by cln-startos's plugins submodule pointing at the deleted Start9Labs/c-lightning-pruning-plugin repo, so the lock file was edited directly (resolved commit + nested @start9labs/start-sdk bumped from 1.3.2 → 1.3.3 to match each sibling's package.json). - Bump StartOS revision 3.3.1:2 → 3.3.1:3 with matching release notes.
npm update bumps: - @types/node 22.19.15 → 22.19.19 - prettier 3.8.1 → 3.8.3 - fast-xml-parser 5.6.0 → 5.7.3 (and dedupes from start-sdk's nested copy) - @nodable/entities 1.1.0 → 2.1.0 (dedupes for the same reason) - nan 2.26.2 → 2.27.0 - strnum 2.2.3 → 2.3.0 - yaml 2.8.3 → 2.9.0 Sibling git deps (bitcoin-core-startos@28.x, cln-startos@master, lnd-startos@master) were already at their branch HEADs.
- New root instructions.md walks first-launch through Bitcoin Core + Electrum indexer + optional Lightning, points at the Select Indexer / Enable Lightning / Configure Indexing actions, and surfaces the 16 GB RAM gate. - Ports the upstream Mempool docs URL out of the manifest's docsUrls into the instructions Documentation section. - Lists the consequential limitations users will run into: mainnet-only, Electrum-only backend, single indexer and single Lightning node at a time, disabled MaxMind/Redis/Stratum/replication/accelerator features. - CLAUDE.md slimmed to a pointer at CONTRIBUTING.md; the "how upstream is pulled" notes move into CONTRIBUTING.md's Updating the upstream version section, covering the frontend+backend tag pair plus the independent MariaDB sidecar tag. - CONTRIBUTING.md reshaped to match the hello-world template.
Replaces the Configure Indexing action with a broader Indexing and Performance action that combines a poll/projection profile, statistics toggle, and the four indexing toggles on one form. Low-CPU (POLL_RATE_MS 8000, MEMPOOL_BLOCKS_AMOUNT 4) is the new default; Balanced (4000/6) and Responsive (2000/8, matching the upstream in-source default) opt in. Existing installs migrate to Low-CPU on upgrade. PROFILES live in utils.ts as the single source of truth for the file-model defaults, migration, and action.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v3.3.1); no change.masterHEADs forbitcoin-core-startos,cln-startos,lnd-startos. Their bundled@start9labs/start-sdklock entries also moved from 1.3.2 → 1.3.3 to match each sibling's actualpackage.json.@types/node,prettier,fast-xml-parser,@nodable/entities,nan,strnum,yamlpicked up patch/minor refreshes vianpm update(no nested duplicate entries left over).3.3.1:2→3.3.1:3(file renamed in place; no migration needed; the migration block carries over for the same0.3.5.1 → 3.3.1jump it already handled).Breaking change fixed
SDK 1.5.0 added
effects.notification, so itsEffectsshape diverges from 1.3.x.sdk.action.createTask'sGetActionInputType<T>isT extends Action<...> ? I : never—Action'srun/getInput/exportMetadatareferenceEffects, so the bitcoin-core-startos-providedautoconfig(typed against 1.3.3'sAction) no longer structurally matches 1.5.0'sAction, and the inferred input narrowed tonever. Fixed by castingautoconfigto our SDK'sAction<'autoconfig', typeof _autoconfig['_INPUT']>instartos/dependencies.ts. The same workaround will be unnecessary oncebitcoin-core-startositself ships on 1.5.0.Operational note: npm update is blocked upstream
npm update(andnpm installfrom a fresh state) fails becausecln-startos'spluginssubmodule (lightningd/plugins) pins a commit that lists the missing-from-GitHubStart9Labs/c-lightning-pruning-pluginrepo. npm hard-codes--recurse-submoduleson git deps with no flag to opt out. Two workarounds in use here:package-lock.jsonresolved commits directly to bump the Start9 sibling refs.npm updatefor registry deps was run with agitshim onPATHthat strips--recurse-submodulesfrom the clone invocation, letting npm finish without touching the broken nested submodule (the cached repo only needs typings).Both are session-local; nothing in the repo depends on either workaround. The real fix lives in
lightningd/plugins(or in cln-startos pinning a differentpluginscommit), and this will keep biting future SDK bumps in every package that depends oncln-startosuntil then.Test plan
Replaces #52 (auto-closed when its head branch was renamed).