Skip to content

chore: bump start-sdk to 3.1.0; 1.163.0:1 → 1.163.0:2 - #102

Merged
MattDHill merged 2 commits into
masterfrom
chore/start-sdk-3.1.0
Oct 19, 2026
Merged

MattDHill merged 2 commits into
masterfrom
chore/start-sdk-3.1.0

Conversation

@MattDHill

@MattDHill MattDHill commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Bumps @start9labs/start-sdk to 3.1.0, which adds Forward Email to the SMTP provider presets in this package's SMTP settings, and bumps the revision with release notes for it.

Also maps the selected SMTP security onto Synapse's email.force_tls, for both custom and system SMTP. Without it Synapse always connected in plaintext and upgraded with STARTTLS, so a server set to TLS (implicit TLS, port 465), the new preset included, never got a TLS handshake and email notifications timed out. The release notes cover the fix, and README and instructions describe the two modes.

🤖 Generated with Claude Code

Picks up the Forward Email SMTP provider preset.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MattDHill
MattDHill requested a review from helix-a October 19, 2026 19:50

@helix-a helix-a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Honor the SMTP security mode before exposing the new preset.

SDK 3.1.0 defaults Forward Email to TLS on port 465, but startos/main.ts copies only its host/port/credentials into Synapse's email block, discarding smtpCredentials.security. Synapse 1.163.0 defaults email.force_tls to false; require_transport_security: true requires STARTTLS, not implicit TLS. Choosing the new preset with its defaults therefore attempts plaintext SMTP against an implicit-TLS listener and times out instead of sending notifications.

The proposal sets email.force_tls from the selected security mode for both custom and system SMTP, models the field, and documents TLS/STARTTLS behavior in README and instructions. It also corrects the same existing mapping error for other TLS presets. Verified the config semantics against Synapse v1.163.0's emailconfig.py and send_email.py.

Proposed changes: e3cfff1...proposal/102

Verification: merge-tree against master passes; SDK 3.1.0 matches npm's latest; two npm installs leave the lockfile unchanged. The original head and proposal both pass make x86 (typecheck, formatting, bundle, pack), and the returned s9pk manifests were inspected. A mocked-effects check exercising the proposal's actual main function passes custom/system TLS, custom/system STARTTLS, and disabled SMTP. All three PR CI checks pass, including x86 and arm builds. Live email delivery was not tested.

Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol

Synapse connects in plaintext and upgrades with STARTTLS unless force_tls is set, so a TLS-mode SMTP server (port 465) never received a TLS handshake. Map the selected security onto force_tls for custom and system SMTP.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MattDHill
MattDHill requested a review from helix-a October 19, 2026 20:23

@helix-a helix-a left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SMTP security issue from my previous review is resolved in 7110b62. Both custom and system SMTP now map the selected mode to email.force_tls, and the file model, README, instructions, and localized release notes agree. The implementation matches the proposal I previously checked for custom/system TLS, custom/system STARTTLS, and disabled SMTP; the documentation variation is fine.

Verified merge-tree against current master, SDK 3.1.0 against npm's latest, and git diff --check. Ran helix-build --output synapse_x86_64.s9pk -- make x86 on the updated head: typecheck, formatting, bundling, and packing pass; inspected the returned manifest. Live email delivery was not tested. CI architecture builds were still running when inspected; this approval does not claim they have passed.

Helix-Harness: pi
Helix-Model: openai-codex/gpt-6.1-sol

@MattDHill
MattDHill merged commit 64e2d5f into master Oct 19, 2026
4 checks passed
@MattDHill
MattDHill deleted the chore/start-sdk-3.1.0 branch October 19, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants