This repository was archived by the owner on Dec 7, 2021. It is now read-only.
Yue playground#43
Open
assassins567 wants to merge 29 commits intomasterfrom
Open
Conversation
…lgorithm is initially finished
Collaborator
|
Could you remove all your local files from obj? |
Collaborator
Author
ok, I do it now |
Collaborator
|
It would also be good if you split up the one big function into three smaller functions:
this will make testing and integration easier |
Collaborator
|
Please again remove all files in test/ada/obj as well as in external/controller/obj |
HClassen
reviewed
Jul 9, 2020
Collaborator
HClassen
left a comment
HClassen
left a comment
There was a problem hiding this comment.
There are still some binary files in you branch which should be removed. Also there a some merch conflicts to be resolved. After that is done the branch can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs demands from back-end at forks and crosses