Skip to content

Overhaul RSVP reading presets and protect natural punctuation timing - #157

Merged
Steadyx merged 5 commits into
mainfrom
feat/rsvp-preset-overhaul
Sep 10, 2026
Merged

Steadyx merged 5 commits into
mainfrom
feat/rsvp-preset-overhaul

Conversation

@Steadyx

@Steadyx Steadyx commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

What changed

The built-in RSVP profiles now provide distinct reading rhythms: Balanced and Chill use short phrases, Narrative adds gentle expression, Focus stays single-word, Flow groups up to three words, Skim replaces the Sprint label, and Study protects difficult terms. Switching profiles preserves reading speed and visual aids. A versioned migration updates built-in cadence without replacing saved or unsaved custom settings.

Punctuation now settles consistently on the final visible word. In a Balanced fixture, home. Then and home. then both display for 737 ms; previously they differed at 620 ms and 465 ms. Full stops retain their pause after short sentences, longer sentences may earn extra time, and live speed changes scale reading time independently of the punctuation hold. Playback and pace estimation share the generated punctuation decision, preserving abbreviation and numeric-separator handling.

CI also exposed seven dependency-freshness advisories after newer libraries were published. GradleDependency is now informational, alongside the existing AGP update advisory. Pinned runtime versions are unchanged, while warningsAsErrors, abortOnError, and correctness/security checks remain enabled.

Risk

This intentionally changes cadence and effective reading speed. Source positions, split-word resume cursors, and inline context are covered by regression and phone tests. Timing and rendering checks do not establish comprehension improvements; reading feel still needs personal evaluation. The persisted SPRINT identifier remains compatible despite its new Skim label.

Validation

  • ./gradlew qualityCheck including pre-push hooks
  • ./gradlew qualityGate on committed HEAD
  • Android Lint passed
  • Focused regression tests added or updated; 810 unit tests passed
  • git diff --check
  • 13 phone checks passed on CPH2493 / Android 16, including context layout, preset switching, split-word resume, and a normal-runtime punctuation exposure test without Compose test-clock advancement

Quality policy

  • No baseline, ignoreFailures, broad exclusion, or unrelated threshold relaxation was added
  • Only dependency-freshness advice (GradleDependency) was reclassified as informational, with an adjacent explanation; no correctness check was suppressed
  • No generated files, debug logging, commented-out code, or unrelated formatting churn is included

@Steadyx
Steadyx merged commit c7a389a into main Sep 10, 2026
1 check passed
@Steadyx
Steadyx deleted the feat/rsvp-preset-overhaul branch September 13, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant