Repository navigation
Overhaul RSVP reading presets and protect natural punctuation timing - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The built-in RSVP profiles now provide distinct reading rhythms: Balanced and Chill use short phrases, Narrative adds gentle expression, Focus stays single-word, Flow groups up to three words, Skim replaces the Sprint label, and Study protects difficult terms. Switching profiles preserves reading speed and visual aids. A versioned migration updates built-in cadence without replacing saved or unsaved custom settings.
Punctuation now settles consistently on the final visible word. In a Balanced fixture,
home. Thenandhome. thenboth display for 737 ms; previously they differed at 620 ms and 465 ms. Full stops retain their pause after short sentences, longer sentences may earn extra time, and live speed changes scale reading time independently of the punctuation hold. Playback and pace estimation share the generated punctuation decision, preserving abbreviation and numeric-separator handling.CI also exposed seven dependency-freshness advisories after newer libraries were published.
GradleDependencyis now informational, alongside the existing AGP update advisory. Pinned runtime versions are unchanged, whilewarningsAsErrors,abortOnError, and correctness/security checks remain enabled.Risk
This intentionally changes cadence and effective reading speed. Source positions, split-word resume cursors, and inline context are covered by regression and phone tests. Timing and rendering checks do not establish comprehension improvements; reading feel still needs personal evaluation. The persisted SPRINT identifier remains compatible despite its new Skim label.
Validation
./gradlew qualityCheckincluding pre-push hooks./gradlew qualityGateon committed HEADgit diff --checkQuality policy
ignoreFailures, broad exclusion, or unrelated threshold relaxation was addedGradleDependency) was reclassified as informational, with an adjacent explanation; no correctness check was suppressed