Skip to content

Fix RSVP chapter progress and sweep restoration - #159

Merged
Steadyx merged 6 commits into
mainfrom
fix/rsvp-progress-restoration
Sep 13, 2026
Merged

Steadyx merged 6 commits into
mainfrom
fix/rsvp-progress-restoration

Conversation

@Steadyx

@Steadyx Steadyx commented Sep 13, 2026 •

Copy link
Copy Markdown
Owner

What changed

Reader and RSVP now use the same source-word chapter progress: opening RSVP at 75% through a chapter remains at 75%, regardless of the book-wide percentage or the playback starting point.

RSVP sweep navigation now covers the full current chapter after a midway launch, saved-state restoration, landscape/portrait layout changes, and settings reloads. The drag handler reads the current playback context rather than retaining an earlier frame list.

Full navigation reuses the cached chapter generation. When the selected word falls inside a grouped unit, only that unit is split around the selection; the remaining chapter retains its cached segmentation. Playback effects and indexing run off the UI thread, and startup timing stays attached to the selected position.

Risk

Source-frame alignment and startup ramps are the main sensitive areas. Unit and device regressions cover exact split-word restoration, complete source-word coverage, forward/backward sweep bounds, resumed timing, progress parity, presets, and punctuation holds. Sweep remains scoped to the current chapter. Device rotation coverage combines portrait/landscape-sized layouts with saved-state recreation.

Validation

  • ./gradlew qualityCheck — 840 unit tests passed
  • ./gradlew qualityGate — passed on the final commit, including Android Lint and APK assembly
  • Focused regression tests added for chapter progress, complete navigation bounds, cached generation reuse, bounded grouped-unit rebuilding, and startup/resume timing
  • git diff --check
  • 11 connected Android device checks passed: 2 sweep/performance tests plus 9 existing progress, playback, preset, split-word, and punctuation tests

On the connected CPH2493 / Android 16 debug build, a 5,000-word single-word-frame fixture took 1,069 ms for cold preparation and 30/23/25 ms for cached reload preparation. These are observational timings, not universal latency guarantees. Frame preparation runs off the UI thread; swipes use the prepared frame list.

Quality policy

  • No baseline, ignoreFailures, broad exclusion, or unrelated threshold relaxation was added
  • No new suppression was added
  • No generated files, debug logging, commented-out code, or unrelated formatting churn is included in production code

@Steadyx Steadyx changed the title Fix RSVP progress to match Reader chapter position Fix RSVP chapter progress and sweep restoration Sep 13, 2026
@Steadyx
Steadyx merged commit 36d0359 into main Sep 13, 2026
1 check passed
@Steadyx
Steadyx deleted the fix/rsvp-progress-restoration branch September 13, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant