Repository navigation
Feat/rsvp expressive reading - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Improve RSVP phrasing and pacing, preserve local author emphasis from EPUB/HTML, and keep English-specific language rules scoped to English books.
Shorten cold startup by playing a prepared opening while the chapter loads. Keep words and saved positions aligned during handoff, and make the full chapter available for replay and swiping as soon as it is ready. Also update Kotlin and the Compose compiler to 2.4.21 to resolve the lint failure.
Risk
Changes affect frame timing, source-position alignment, and navigation during startup. Regression tests cover pause/resume, skipped or repeated words, chapter endings, and navigation outside the opening buffer.
Validation
Local full
qualityGatepassed, including lint and all 914 unit tests. All 18 device tests passed on CPH2493 / Android 16; committed snapshot checks and Git hooks also passed../gradlew qualityCheck./gradlew qualityGatewhen Android/UI/build behavior changedgit diff --checkQuality policy
ignoreFailures, broad exclusion, or unrelated threshold relaxation was added