Skip to content

Conversation

@WilsontheWolf
Copy link
Member

@WilsontheWolf WilsontheWolf commented Sep 23, 2025

This is a proof of concept PR for loading mods from zip files. This is missing a few important features, and will probably rely on lovely getting support as well first.

  • Mods from zips cannot be disabled (a zip can't have a .lovelyignore inserted in it)
    • A zip with a .lovelyignore in it will be treated as disabled and unable to be reanbled
    • This will likely stay broken until lovely decides how it will disable zipped mods
  • SMODS cannot find itself in a zip yet
    • Will likely need lovely support to properly test.
  • Lovely will likely need some different behaviour for zips with dirs in them (since otherwise every download from github source will not be loaded by lovely). SMODS currently behaves like a zip is a folder in respect to if a mod has a lovely counterpart or not.

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • I didn't make new lovely files or all new lovely files have appropriate priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants