Bell#211
Draft
suprohub wants to merge 5 commits into
Draft
Conversation
JunkyDeveloper
suggested changes
Jun 14, 2026
JunkyDeveloper
left a comment
JunkyDeveloper
left a comment
Contributor
There was a problem hiding this comment.
Still needed to be checkout and tested if it really works
| } | ||
|
|
||
| pub fn main() { | ||
| // |
| fn get_state_for_placement(&self, context: &BlockPlaceContext<'_>) -> Option<BlockStateId> { | ||
| let clicked_face = context.clicked_face; | ||
| let pos = context.clicked_pos.relative(clicked_face); | ||
| println!( |
Contributor
There was a problem hiding this comment.
Don't use println! use tracing or delete it
| } | ||
|
|
||
| fn can_survive(&self, state: BlockStateId, world: &dyn LevelReader, pos: BlockPos) -> bool { | ||
| let support_dir = Self::get_connected_direction(state); // уже направление к опоре |
Contributor
There was a problem hiding this comment.
remove russian comment!
please use onnly english
| fn can_survive(&self, state: BlockStateId, world: &dyn LevelReader, pos: BlockPos) -> bool { | ||
| let support_dir = Self::get_connected_direction(state); // уже направление к опоре | ||
| if support_dir == Direction::Down { | ||
| // колокол висит на потолке → опора сверху |
Comment on lines
+304
to
+305
| // get_collision_shape не переопределён – используется стандартная реализация, | ||
| // которая берёт форму из Block (state.get_collision_shape()). |
|
This pull request has conflicts with the base branch "master". Please resolve those so we can test out your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bell & middle click entity to get item