Implement ender pearls#233
Open
Purdze wants to merge 12 commits into
Open
Conversation
Joniii11
suggested changes
Jun 26, 2026
Joniii11
left a comment
Joniii11
left a comment
Contributor
There was a problem hiding this comment.
i only found this elkse it LGTM
| let world = context.world; | ||
|
|
||
| // Vanilla throw pitch: 0.4 / (random * 0.4 + 0.8). | ||
| let pitch = 0.4 / (rand::random::<f32>() * 0.4 + 0.8); |
Contributor
There was a problem hiding this comment.
why not use world.random().lock()
Contributor
There was a problem hiding this comment.
hmm in https://mcsrc.dev/1/26.2/net/minecraft/world/item/EnderpearlItem#L33 it use world random, so do you consider for perfect parity it's necessary or we can neglect that ? (purdze) I know that it's important for speedrun or very specific mechanics that use world random, or we can use any random ?
Contributor
There was a problem hiding this comment.
obviously i would use it lol and if we already have access to world why not use it?
Contributor
There was a problem hiding this comment.
it can be for performance because lock the world can have a cost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ender pearls with flight, collision, owner teleport, chunk loading and player bound persistence.