Repository navigation
fix: make async client close graceful - #114
Merged
Merged
Conversation
16 of 18 tasks
xxvw
marked this pull request as ready for review
July 27, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompletionExceptionidentity and cleanup failuresRelated Issue
Closes #109
Type of Change
Checklist
main.mvn clean verify.Testing
All 113 tests passed, including deterministic queued, in-flight, acceptance-race, executor-rejection, post-close, cleanup-failure, and exception-identity cases.
Notes
close()remains non-blocking for accepted work. Deferred transport cleanup failures are surfaced through the final accepted future. Merge #113 after this pull request to add the consolidated changelog entry.