fix: add missing makeAgent helper, annotateTtlWarning function, and registered_at field in tests

[otobongdev]

…
Closes #380

Summary by CodeRabbit

• New Features

  • Service registry entries now display a TTL warning when they approach expiration.

• Bug Fixes

  • TTL warnings are omitted when ledger information is unavailable, preventing inaccurate status indicators.

• Tests

  • Updated registry and sorting test coverage with more complete service and agent data.

[coderabbitai]

Warning

Review limit reached

@otobongdev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b82293dd-930a-482f-905a-ecc88cb071e2

📥 Commits

Reviewing files that changed from the base of the PR and between 21015c9 and 4e211c6.

📒 Files selected for processing (1)

• frontend/lib/sort.test.ts

📝 Walkthrough

Walkthrough

Adds backend service TTL warning annotation based on ledger age and updates frontend test fixtures with registration data and a reusable agent factory.

Changes

Registry and test updates

Layer / File(s)	Summary
Service TTL warning annotation backend/src/routes/registry.js	Adds annotateTtlWarning to attach ttl_warning when the current ledger reaches the configured warning threshold.
Frontend test fixture support frontend/__tests__/RegistryPage.test.tsx, frontend/lib/sort.test.ts	Adds registered_at to service fixtures and introduces a reusable AgentEntry factory with overrides.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• Stellar-Ecosystem/lodestar#201: Related agent sorting helpers and test setup.
• Stellar-Ecosystem/lodestar#225: Related server-side TTL warning behavior.
• Stellar-Ecosystem/lodestar#258: Related changes to annotateTtlWarning.

Suggested reviewers: naninu123

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR changes backend routing and test helpers, but it does not add the requested favicon or app icons for #380.	Add frontend/app/icon.png and frontend/app/apple-icon.png with the Lodestar mark, and ensure Next.js emits the favicon and touch icon.
Out of Scope Changes check	⚠️ Warning	The backend TTL warning and sorting test helper changes are unrelated to the icon work requested by #380.	Remove unrelated backend and test changes, or split them into a separate PR focused on the favicon and app icons.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the helper, TTL warning, and test fixture changes in this PR.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/lib/sort.test.ts`:
- Around line 4-12: Update the makeAgent helper to provide default values for
every required AgentEntry property defined in the AgentEntry type, then spread
overrides last so callers can customize any field while preserving complete
type-safe test fixtures.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e925a14a-9de8-4391-a08e-f64992b69461

📥 Commits

Reviewing files that changed from the base of the PR and between a3fd824 and 21015c9.

⛔ Files ignored due to path filters (1)

• frontend/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

• backend/src/routes/registry.js
• frontend/__tests__/RegistryPage.test.tsx
• frontend/lib/sort.test.ts

[ritik4ever]

Hi @otobongdev,

This PR could not be merged because it has merge conflicts with the target branch.

Please resolve the merge conflicts, push the updated changes, and the PR can be reviewed and merged.

Thank you!

[otobongdev]

done