Fix clippy warnings and pipeline issues

[walterthesmart]

Replaces unnecessary map_or with is_some_and to resolve clippy strict warnings breaking the CI pipeline.

Summary by CodeRabbit

• Style

  • Code formatting improvements and import reorganization for enhanced readability across test files

• Chores

  • Build configuration adjustments to test module compilation behavior

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 835d0442-d222-4d24-affa-b8576336a82a

📥 Commits

Reviewing files that changed from the base of the PR and between 3445720 and 40fd3b8.

📒 Files selected for processing (4)

• contracts/identity/tests/core.rs
• contracts/state_channel/src/test.rs
• contracts/vision_records/src/lib.rs
• contracts/zk_verifier/tests/test_exports.rs

💤 Files with no reviewable changes (1)

• contracts/state_channel/src/test.rs

---

Walkthrough

Three test and contract files undergo updates: one function signature is reformatted for improved readability, a test-only compilation gate is removed from a module, and import statements and whitespace are reorganized in a test file. No functional logic changes occur.

Changes

Cohort / File(s)	Summary
Function Signature Formatting contracts/identity/tests/core.rs	make_valid_proof function signature expanded from single-line to multi-line format for enhanced readability without altering parameter or return types.
Compilation Gate Removal contracts/state_channel/src/test.rs	#![cfg(test)] attribute removed from test module, allowing test code to compile in non-test builds and potentially introduce test dependencies into production binaries.
Import and Whitespace Reorganization contracts/zk_verifier/tests/test_exports.rs	Import statements reordered and incidental blank lines adjusted throughout the file; no logic or control flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• feat(identity): add ZK-based credential proof verification #206: Directly modifies the same make_valid_proof function signature in the identity test module.

Poem

✨ Formatting lines with care,
Reorganizing code here and there,
One gate removed from the test door—
Now audit closely to explore! 🔍

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title claims to fix 'clippy warnings and pipeline issues', but the actual changes include function signature formatting, removal of cfg(test) attributes, and import reordering—not clippy warning fixes.	Update the title to accurately reflect the actual changes, such as 'Refactor function signatures and restructure test modules' or clarify what specific clippy warnings were addressed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-clippy-warnings-ci

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}