feat: resolve issues #559, #563, #564, #567#671
Merged
yahia008 merged 6 commits intoMay 28, 2026
Conversation
|
Hey @Chibey-max! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four wave-ready issues in a single PR.
#559 — Emit event when oracle admin is rotated
admin_rotevent toupdate_admincarrying(old_admin, new_admin)test_update_admin_emits_rotation_event#563 — Store submission ledger in oracle ResultEntry
submitted_ledger: u32field toResultEntryenv.ledger().sequence()insubmit_resulttest_submit_result_stores_submitted_ledger#564 — Store submitting admin address in oracle ResultEntry
submitter: Addressfield toResultEntrysubmit_resulttest_submit_result_stores_submitter#567 — Release game_id on cancelled/expired matches
cancel_matchnow removesDataKey::GameIdfrom persistent storageexpire_matchnow removesDataKey::GameIdfrom persistent storagetest_game_id_released_after_cancelandtest_game_id_released_after_expireFiles changed
contracts/oracle/src/lib.rscontracts/oracle/src/types.rscontracts/escrow/src/lib.rscontracts/escrow/src/tests.rs