Skip to content

feat: resolve issues #559, #563, #564, #567#671

Merged
yahia008 merged 6 commits into
StellarCheckMate:mainfrom
Chibey-max:feat/issues-559-563-564-567
May 28, 2026
Merged

feat: resolve issues #559, #563, #564, #567#671
yahia008 merged 6 commits into
StellarCheckMate:mainfrom
Chibey-max:feat/issues-559-563-564-567

Conversation

@Chibey-max
Copy link
Copy Markdown
Contributor

Summary

Resolves four wave-ready issues in a single PR.


#559 — Emit event when oracle admin is rotated

  • Added admin_rot event to update_admin carrying (old_admin, new_admin)
  • Added test_update_admin_emits_rotation_event

#563 — Store submission ledger in oracle ResultEntry

  • Added submitted_ledger: u32 field to ResultEntry
  • Populated from env.ledger().sequence() in submit_result
  • Added test_submit_result_stores_submitted_ledger

#564 — Store submitting admin address in oracle ResultEntry

  • Added submitter: Address field to ResultEntry
  • Populated from the verified admin address in submit_result
  • Added test_submit_result_stores_submitter

#567 — Release game_id on cancelled/expired matches

  • cancel_match now removes DataKey::GameId from persistent storage
  • expire_match now removes DataKey::GameId from persistent storage
  • Added test_game_id_released_after_cancel and test_game_id_released_after_expire

Files changed

  • contracts/oracle/src/lib.rs
  • contracts/oracle/src/types.rs
  • contracts/escrow/src/lib.rs
  • contracts/escrow/src/tests.rs

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

Hey @Chibey-max! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#559 Feature: emit an event when oracle admin is rotated Link to this issue
#564 Feature: store the submitting admin address in oracle ResultEntry Link to this issue
#567 Feature: decide whether cancelled or expired matches should release game_id for rematches Link to this issue
#563 Feature: store submission ledger or timestamp in oracle ResultEntry Link to this issue

ℹ️ Learn more about linking PRs to issues

@yahia008 yahia008 merged commit 5fe3bc7 into StellarCheckMate:main May 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants