test: assert instance TTL is refreshed after deposit#683
Merged
yahia008 merged 2 commits intoMay 28, 2026
Conversation
Deposit is a hot path that reads instance config (Oracle, Admin, Paused). Extend instance TTL on every deposit so those entries stay alive, and add a test that advances the ledger then calls deposit and asserts the instance TTL equals MATCH_TTL_LEDGERS.
|
@D-Ochuko Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #619
Deposit is a hot path that reads instance config (Oracle, Admin, Paused). Extend instance TTL on every deposit so those entries stay alive, and add a test that advances the ledger then calls deposit and asserts the instance TTL equals MATCH_TTL_LEDGERS.
Changes made:
contracts/escrow/src/lib.rs — added env.storage().instance().extend_ttl(MATCH_TTL_LEDGERS, MATCH_TTL_LEDGERS) at the end of deposit, so the instance storage (which holds Oracle, Admin, MatchCount, Paused config) stays alive on every deposit call.
contracts/escrow/src/tests.rs — added Instance as _ to the existing storage testutils import, and added the new test test_instance_ttl_refreshed_after_deposit which advances the ledger by 1000 sequences after create_match, calls deposit, then
asserts the instance TTL equals MATCH_TTL_LEDGERS.