feat(marketplace): add sortable face value and deadline columns (#35) - #51
Open
apatafamilycompound123-ops wants to merge 1 commit into
Conversation
Add clickable sort headers to the invoice marketplace for Face Value and Deadline. Each column cycles ascending, descending, then resets to the default order, with a direction arrow shown on the active column. The active sort is persisted in URL query params and reset when filters are cleared. Includes unit tests for the sorting helpers and sort header.
|
@apatafamilycompound123-ops Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@Chucks1093 done closes #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds sortable column headers to the invoice marketplace so investors can compare invoices by face value or funding deadline without manually scrolling.
Implements #35.
Scope
?sort=faceValue&order=asc,?sort=deadline&order=asc) so it survives a page refreshChanges
lib/invoice-sort.ts— pure helpers:cycleSort,sortInvoices,parseSortState,serializeSortStatecomponents/marketplace/sort-header.tsx— presentational sort header with direction indicatorsapp/marketplace/page.tsx— wires sort state, URL persistence, and applies sorting to the filtered listAcceptance Criteria
Testing
New tests:
lib/__tests__/invoice-sort.test.ts(13) andcomponents/marketplace/__tests__/sort-header.test.tsx(4) — all passing. Pre-existingrecentlyViewedlocalStoragejsdom failures are unrelated (present on baseline).Closes #35