Skip to content

test(vault): Add over-funding regression test#238

Open
gerani1 wants to merge 6 commits into
StellarYield:mainfrom
gerani1:fix/issue-150-over-funding-test
Open

test(vault): Add over-funding regression test#238
gerani1 wants to merge 6 commits into
StellarYield:mainfrom
gerani1:fix/issue-150-over-funding-test

Conversation

@gerani1
Copy link
Copy Markdown
Contributor

@gerani1 gerani1 commented Mar 29, 2026

Adds a regression test to verify that deposits slightly exceeding the funding target are rejected cleanly. Also annotates failing tests resulting from the known storage Enum overlap bug.

Fixes #181

Pull Request Checklist

General

  • PR title follows conventional commit format (type(scope): description)
  • Branch name follows issue-<number>-<description> format
  • Linked to relevant issue(s) with Closes #<number> or Fixes #<number>
  • Description clearly explains what changes were made and why
  • Breaking changes documented (if applicable)

Code Quality

  • Code follows project style guidelines (make fmt passes)
  • No clippy warnings (make lint passes)
  • No new panic! statements (use panic_with_error! instead)
  • Public functions have proper documentation
  • Complex logic is explained with comments

Testing

  • All existing tests still pass (make test passes)
  • New functionality is covered by tests
  • Test coverage meets minimum requirements (90%+ for new features)
  • Tests follow naming conventions (test_<functionality>_scenario)
  • Edge cases and error conditions are tested

Security & Events

  • Access control properly implemented and tested
  • All state changes emit appropriate events
  • Input validation is comprehensive
  • Reentrancy protection where needed
  • CEI pattern (Checks-Effects-Interactions) followed

Documentation

  • README updated (if applicable)
  • API documentation updated (if applicable)
  • Architecture docs updated (if applicable)
  • Examples added or updated (if applicable)

Description

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Security improvement

Testing

Security Considerations

Screenshots / Diagrams

Additional Context

Reviewer Focus Areas


By submitting this PR, I confirm that:

  • I have read and followed the contribution guidelines
  • My code follows the project's style standards
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have tested my changes thoroughly
  • I understand that this PR may be closed if I don't respond to feedback in a timely manner

Adds a regression test to verify that deposits slightly exceeding the funding target are rejected cleanly. Also annotates failing tests resulting from the known storage Enum overlap bug.

Fixes StellarYield#181
Co-Authored-By: Claude <noreply@anthropic.com>
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Mar 29, 2026

@gerani1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Test for Funding Target Slightly Exceeded

2 participants