test(vault): Add over-funding regression test#238
Open
gerani1 wants to merge 6 commits into
Open
Conversation
Adds a regression test to verify that deposits slightly exceeding the funding target are rejected cleanly. Also annotates failing tests resulting from the known storage Enum overlap bug. Fixes StellarYield#181 Co-Authored-By: Claude <noreply@anthropic.com>
|
@gerani1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ssing field for escrow tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test to verify that deposits slightly exceeding the funding target are rejected cleanly. Also annotates failing tests resulting from the known storage Enum overlap bug.
Fixes #181
Pull Request Checklist
General
type(scope): description)issue-<number>-<description>formatCloses #<number>orFixes #<number>Code Quality
make fmtpasses)make lintpasses)panic!statements (usepanic_with_error!instead)Testing
make testpasses)test_<functionality>_scenario)Security & Events
Documentation
Description
Type of Change
Testing
Security Considerations
Screenshots / Diagrams
Additional Context
Reviewer Focus Areas
By submitting this PR, I confirm that: