test(vault_factory): verify vault count correctness after multiple removals#245
Open
Majormaxx wants to merge 2 commits into
Open
test(vault_factory): verify vault count correctness after multiple removals#245Majormaxx wants to merge 2 commits into
Majormaxx wants to merge 2 commits into
Conversation
added 2 commits
March 29, 2026 23:12
Add test_partial_early_redemption_then_full_redemption_at_maturity to test_redemption.rs. The test covers: - Stage 1: user redeems half their shares early via request_early_redemption and process_early_redemption; asserts payout equals assets minus 2% fee - Yield distribution between the two redemption stages - Stage 2: user redeems remaining shares at maturity via redeem_at_maturity; asserts payout includes pending yield - Final state: user holds zero vault shares; total received >= deposited principal No non-test code changes. Closes StellarYield#194
…movals Add test_vault_count_correct_after_multiple_removals to tests.rs. Creates five vaults, removes the first, middle, and last vault in sequence, and after each removal asserts: - get_vault_count() decrements correctly - get_all_vaults() excludes removed vaults and retains the rest - get_single_rwa_vaults() reflects the same exclusions - is_registered_vault() returns false for removed vaults - instance-storage counter always equals the vault list length No non-test code changes. Closes StellarYield#192
|
@Majormaxx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_vault_count_correct_after_multiple_removalstovault_factory/src/tests.rsget_vault_count()decrements correctlyget_all_vaults()excludes removed vaults and retains the restget_single_rwa_vaults()reflects the same exclusionsis_registered_vault()returnsfalsefor removed vaultsTest plan
cargo test -p vault_factory -- test_vault_count_correct_after_multiple_removalscargo test -p vault_factory— 28 passed, 0 failedCloses #192